Add a timeout #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the timeout the request expires immediately and results in the `HTTPClientError.deadlineExceeded`. I'm not sure why the async methods of AsyncHTTPClient don't allow a `nil` deadline like other methods (to use the overall client default). This patch makes it work, but maybe there should be a more general way to configure the timeout.
dimitribouniol
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks for catching this! (probably not the first bug introduced from copy pasting everything from a working implementation into a package without deploying it somewhere first 🙈)
I'll likely make this configurable with other proxy settings at the init site, but 2s is as good as anything at this point in time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the timeout the request expires immediately and results in the
HTTPClientError.deadlineExceeded.I'm not sure why the async methods of AsyncHTTPClient don't allow a
nildeadline like other methods (to use the overall client default).This patch makes it work, but maybe there should be a more general way to configure the timeout.